Fixed issue: https://github.com/Azure/azure-rest-api-specs/issues/4721 by irrogozh · Pull Request #5087 · Azure/azure-rest-api-specs

irrogozh · 2019-01-24T18:57:55Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-01-24T19:03:35Z

Automation for azure-sdk-for-js

A PR has been created for you:
Azure/azure-sdk-for-js#1004

AutorestCI · 2019-01-24T19:03:36Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_network-january-release
  stderr: 'To https://github.com/Azure/azure-sdk-for-ruby.git
 ! [rejected]            restapi_auto_network-january-release -> restapi_auto_network-january-release (fetch first)
error: failed to push some refs to 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-ruby.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

azuresdkci · 2019-01-24T19:04:17Z

Can one of the admins verify this patch?

AutorestCI · 2019-01-24T19:11:52Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4233

dsgouda · 2019-01-24T19:17:12Z

@irrogozh do you plan to release this fix for all the versions that were released starting 2018-02-01, you will have to release SDK packages for each one of these API versions
Please consult with @MikhailTryakhov regarding this

AutorestCI · 2019-01-24T19:18:58Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#3937

AutorestCI · 2019-01-24T19:45:18Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4596

AutorestCI · 2019-01-24T19:55:32Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_network-january-release
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

MikhailTryakhov · 2019-01-28T11:49:18Z

Please change only latest api version

…in 2018-12-01

MikhailTryakhov

LGTM

MikhailTryakhov · 2019-01-29T06:31:03Z

@irrogozh
need to take a look at CI jobs results

EvgenyAgafonchikov · 2019-01-29T06:50:29Z

@irrogozh
need to take a look at CI jobs results

Fails with JavaScript heap out of memory, which is common CI failure for networking now. @dsgouda as FYI

dsgouda · 2019-01-29T17:39:48Z

@marstr do you know someone who can take a look at the out of mem errors

anton-evseev · 2019-02-11T13:33:18Z

@dsgouda re-running CI helped to pass OOM errors, please take a look

dsgouda

LGTM

* Adds base for updating Microsoft.Network from version stable/2018-11-01 to version 2018-12-01 * Updates readme * Updates API version in new specs and examples * fixing invalid paths in frontdoor (#4991) * add max bound for application gateway autoscale config (#4996) * fixing location in network samples (#4992) * Fix duplicate path in old Network API versions (#5003) * missing location in route tables (#5024) * removed confusing readonly parameters from example (#5022) * Fix errors in ddosCustomPolicy.json (#5013) * Add ddosCustomPolicy.json to readme.md and fix spec errors (#5008) * Update ddosCustomPolicy.json in 2018-12-01 * Pick AppGw changes from 2018-11-01 (#5044) * Adding the structure of ruleSequence and conditions in rewriteRuleSets under applicationGatewayProperties (#5009) * Added Prepare action for subnet (#5058) * Added Prepare action documentation * Took carte of the errors from the validation tool * Error fixes from validation tool * Adding a typo and a missing property * updated the destination address description to also include service tags (#5112) * Update for Get Application Gateway Server Variables APIs (#5113) * Changes in the existing APIs result format. * adding proxyresource to server variables APIs result * Updating applicationgateway.json * Update applicationGateway.json * add Go SDK build for 2018-12-01 * changes to pythonand ruby readme files * Update readme.ruby.md * adding jave readme changes * Minor Fix in spacing * Creating a new tag for 2018-12 version * Update readme.python.md * Update applicationGateway.json * fixing examples * examples * Fixed issue: #4721 (#5087) * Fixed issue: #4721 * Reverted fixes in networkWatcher in previous versions. Left only fix in 2018-12-01 * Threat Intel changes for Azure Firewall (#5143) * Threat Intel changes for Azure Firewall * Move the property to the end of the list * Fix typos in Network 2018-12-01

Fixed issue: #4721

ecd9aa0

irrogozh requested a review from MikhailTryakhov as a code owner January 24, 2019 18:57

azuresdkci assigned dsgouda Jan 24, 2019

azuresdkci requested a review from dsgouda January 24, 2019 19:10

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR network/resource-manager] Fixed issue: https://github.com/Azure/azure-rest-api-specs/issues/4721 Azure/azure-sdk-for-python#4233

Merged

dsgouda added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jan 24, 2019

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR network/resource-manager] Fixed issue: https://github.com/Azure/azure-rest-api-specs/issues/4721 Azure/azure-sdk-for-go#3937

Closed

AutorestCI mentioned this pull request Jan 24, 2019

[AutoPR network/resource-manager] Fixed issue: https://github.com/Azure/azure-rest-api-specs/issues/4721 Azure/azure-sdk-for-java#2872

Closed

dsgouda added Changes Required and removed DoNotMerge <valid label in PR review process> use to hold merge after approval labels Jan 28, 2019

Reverted fixes in networkWatcher in previous versions. Left only fix …

885bb80

…in 2018-12-01

MikhailTryakhov approved these changes Jan 29, 2019

View reviewed changes

anton-evseev mentioned this pull request Feb 11, 2019

Merge Network release branch into master #5184

Closed

5 tasks

dsgouda approved these changes Feb 11, 2019

View reviewed changes

dsgouda removed the Changes Required label Feb 11, 2019

dsgouda merged commit c0f9183 into Azure:network-january-release Feb 11, 2019

Conversation

irrogozh commented Jan 24, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented Jan 24, 2019

Uh oh!

AutorestCI commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

dsgouda commented Jan 24, 2019

Uh oh!

AutorestCI commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

MikhailTryakhov commented Jan 28, 2019

Uh oh!

MikhailTryakhov left a comment

Choose a reason for hiding this comment

Uh oh!

MikhailTryakhov commented Jan 29, 2019

Uh oh!

EvgenyAgafonchikov commented Jan 29, 2019

Uh oh!

dsgouda commented Jan 29, 2019

Uh oh!

anton-evseev commented Feb 11, 2019

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading

AutorestCI commented Jan 24, 2019 •

edited

Loading